search

peerdavid / remapy

An open source explorer for your remarkable tablet to show, upload or delete files via the remarkable cloud.
Apache License 2.0
174 stars 19 forks source link

evince not installed on every system #6

Closed lschneiderbauer closed 4 years ago

lschneiderbauer commented 4 years ago

Just a minor thing: Your script seems to want to open all pdf files with evince. If it's not installed, the browser does nothing instead. Why not use xdg-open for pdf files as well, as you do for other files?

peerdavid commented 4 years ago

Hi,

thanks for your comment. I will change this and check if evince is installed and use xdg-open as fallback. I prefer evince, because I can open the same page that is currently opened on the remarkable tablet via evince -i

lschneiderbauer commented 4 years ago

That sounds reasonable.

Btw: Thank you for putting time into this project! It's very useful, at least to me.

peerdavid commented 4 years ago

That sounds reasonable.

Btw: Thank you for putting time into this project! It's very useful, at least to me.

You're welcome :) The bug should be fixed with the latest commit, therefore I close this issue. Feel free to reopen it.