search

peerdraft / obsidian-plugin

Collaboration for Obsidian – Sync, Share, and Edit anywhere
https://www.peerdraft.app/
GNU General Public License v3.0
36 stars 2 forks source link

What does the "Join Shared Session" command do? #2

Closed JoelAnderson-UU closed 7 months ago

JoelAnderson-UU commented 7 months ago

What does the "Join Shared Session" command do? It doesn't seem to have any effect. But would very nice to be able to restart a note that was closed, in such a way that collaborators could continue using the same code, rather than having to send them a new code.

Ideally, I'd like to store the relevant share-code URL in a note's Properties (peerdrafid:), and then perhaps click on it to resume sharing.

The main thing though is to be able to reuse the share codes.

schlundd commented 7 months ago

The command should open a popup asking for a peerdraft URL. This is the URL someone else would give you to join their session.

Selection_309

Does it not open the dialog for you?

Regarding the re-use of codes, I'll open a new Feature Request.

JoelAnderson-UU commented 7 months ago

I think I've figured out what's going on: It wasn't clear from your reply or from any of the documentation (or the various YouTube videos explaining this), but it seems that it is now possible for guest-collaborators to establish a peer-to-peer connection, from inside their own instance of Obsidian. Wow!

As I understand it now: it is now possible to join a peer-to-peer session from within another Obsidian vault. Once the host-collaborator shares the URL with the guest-collaborators, the guest-collaborators can open an Obsidian vault on their own computer (as long as the Peerdraft plugin is installed), run the "Join shared session" command, and then paste the URL at the prompt.

What is confusing, however, is that there is no warning about the fact that, if you switch to another note, and try to switch back to the collaboration, the session will have ended. Perhaps there needs to be a pop-up that asks, "Do you want to close this session? Closing this note with end the peer-to-peer connection with Peerdraft."

In any case, it's probably a good idea to warn collaborators to use the "Pin" command to make sure that the collaborative session stays open.

schlundd commented 7 months ago

Thanks for the hint about the pin command. Notes get auto-pinned on starting/joining a session now (#4).