peerigon / phridge

A bridge between node and PhantomJS
The Unlicense
519 stars 44 forks source link

Remove heartbeat for synchronous messages to phantom #14

Closed aju closed 10 years ago

aju commented 10 years ago

This fixes and issue with delays between synchronous calls to phantom using "run" function. In old version when synchronous function was called heartbeat was sent as well cluttering phantom stdin. Between "_send" and "_receive" actions node was sending heartbeat messages which had to be processed by the phantom - even though code run on phantom was synchronous.

jhnns commented 10 years ago

Excellent! :+1: