search

peerigon / phridge

A bridge between node and PhantomJS
The Unlicense
519 stars 44 forks source link

Support Phantomjs 2.0 #30

Closed Stofkn closed 8 years ago

Stofkn commented 9 years ago

Hi!

Is there any support for Phantomjs 2.0 upcoming?

Kind regards Kristof

jhnns commented 9 years ago

The node wrapper for PhantomJS is still deferring the release because of issues with the binaries on Linux and OSX (Medium/phantomjs#288).

Given from the changelog there has not been a breaking change. I've installed the binaries via homebrew and tested phridge against PhantomJS 2.0 and everything was working fine (though I had to adjust a test because an error message has changed).

I've even experienced a huge performance increase of about 400-500% (at least on OSX).

sodawy commented 9 years ago

expect 2.0！

alexpts commented 9 years ago

+1

justin-robinson commented 9 years ago

+1

nathanjohnson320 commented 9 years ago

:+1:

raphaelokon commented 9 years ago

+1

@jhnns Can you explain how to use the phantomJS 2.0 binary instead of the bundled one? Thanks.

jhnns commented 9 years ago

1. Install phantomjs 2.0 (via homebrew)

brew install phantomjs

2. Replace binary inside phridge

rm -rf node_modules/phridge/node_modules/phantomjs/lib/phantom/bin/phantomjs ln /usr/local/bin/phantomjs node_modules/phridge/node_modules/phantomjs/lib/phantom/bin/phantomjs

JonnyBGod commented 8 years ago

PhantomJs 2.1 was release a few days ago. Can we update this now?

jhnns commented 8 years ago

phridge 2.0.0 with PhantomJS 2.1.3 shipped today