Can now pass CLI style JSON props i.e. '--remote-debugger-port':8888

peerigon / phridge

A bridge between node and PhantomJS

The Unlicense

519 stars 50 forks source link

Can now pass CLI style JSON props i.e. '--remote-debugger-port':8888 #32

Closed tecfu closed 9 years ago

tecfu commented 9 years ago

Can now pass CLI style JSON props i.e. '--remote-debugger-port':8888 to phridge.spawn(). This addresses unfixed phantomjs bugs.

See https://github.com/peerigon/phridge/issues/31

coveralls commented 9 years ago

Coverage decreased (-1.75%) to 98.25% when pulling d29e53bf61668f90293274938c9741f6aa3390a4 on tecfu:master into 44ad3380a13673b0811b7cbc5cc13e05e678cd28 on peerigon:master.

coveralls commented 9 years ago

Coverage decreased (-1.75%) to 98.25% when pulling 13af15c9382d9c2cfb8caa50e8d7672a1464f25b on tecfu:master into 44ad3380a13673b0811b7cbc5cc13e05e678cd28 on peerigon:master.

coveralls commented 9 years ago

Coverage decreased (-1.75%) to 98.25% when pulling 13af15c9382d9c2cfb8caa50e8d7672a1464f25b on tecfu:master into 44ad3380a13673b0811b7cbc5cc13e05e678cd28 on peerigon:master.

jhnns commented 9 years ago

Thx for the fix and sorry for being unresponsive. :+1: Please add tests to your pull-requests the next time.

tecfu commented 9 years ago

Ahh...will do. Thanks.