handle killed phantomjs process gracefully

peerigon / phridge

A bridge between node and PhantomJS

The Unlicense

519 stars 50 forks source link

Closed domasx2 closed 9 years ago

domasx2 commented 9 years ago

Hi,

I'm trying to use this for https://github.com/Producters/express-crawler-snapshots. I need it to be fairly robust and handle phantomjs child process crashing or being killed.

I encountered and fixed two issues that pop up when a phantomjs process dies:

ping timeout is never cleared. Callback tries to write to already closed stdin socket and crashes the process
pending deffereds are not rejected, leaving the callers hanging

jhnns commented 9 years ago

Awesome, thx! I haven't thought about the child process being killed autonomously... Also related to #35

jhnns commented 9 years ago

I'll just do some refactoring...