search

peerigon / phridge

A bridge between node and PhantomJS
The Unlicense
519 stars 50 forks source link

support slimerjs? #46

Open laggingreflex opened 8 years ago

laggingreflex commented 8 years ago

I tried using this with slimerjs (replacing the phantomjs module and supplying .path to slimerjs) and it worked, which isn't surprizing as slimer aims to have almost identical API as phantom, and many other phantom bridges support it as well.

thoughts?

jhnns commented 8 years ago

That's interesting. We could provide an option to specify the path. This would allow the developer to pass in the exact version of phantomjs or slimerjs – on their own risk of course :wink:

However, should phantomjs still be a dependency of phridge then?

moshewe commented 8 years ago

I think so, as Phantom is still the default headless browser...

jhnns commented 8 years ago

Yep, sounds reasonable.

mynoheart commented 8 years ago

module child_process not exist in slimerjs, you comment this line in lib/phantom/start.js ?

laggingreflex commented 8 years ago

@mynoheart Hmm, I don't remember commenting that line, no

mynoheart commented 8 years ago

Please, write how you replace phantom to slimer more detail.