search

peerigon / unzip-crx

Unzip chrome extension files
MIT License
52 stars 18 forks source link

Add reference to original source of the crxToZip logic + fix calcLength function #7

Closed Rob--W closed 5 years ago

Rob--W commented 6 years ago

The crxToZip function in your library is copied from crx2ff. While crx2ff credits the original source of the logic (https://github.com/Rob--W/crxviewer/blob/master/src/lib/crx-to-zip.js), your library does not. I suggest that you add a link to the original source of the logic for future reference and to avoid propagation of errors.

Since the original logical fork by crx2ff, I updated the CRX parser to support the CRX3 format and to fix a flaw in the calcLength function. Someone has already sent a PR for the CRX3 format (#5), so you could merge that and add another patch to fix the calcLength flaw: https://github.com/Rob--W/crxviewer/commit/420214409ed62aa88de877efbd45f0cf5cd9cb3a

hpohlmeyer commented 5 years ago

Thanks for pointing that out! We merged #5 today and added credit to the original source in #8.
Let me know, if this is fine with you.

And apologies for not giving credit in the first place.