search

peeringdb / peeringdb-py

PeeringDB python client
BSD 2-Clause "Simplified" License
86 stars 21 forks source link

Allow option for logging to co-exist with existing loggers #67

Open jhay317 opened 1 year ago

jhay317 commented 1 year ago

Currently in the init.py a reset is performed for all loggers that exist. This can cause issues when this is integrated into other applications where logging is utilized. Two options on how this can be resolved are either an addition to the configuration file to allow_other_loggers: True or to expose the logger that exists within the PeeringDB API to be added to existing loggers. This is pretty common with other libraries.

grizz commented 1 year ago

Good point, thanks!

@peeringdb/pc This should get a priority for release.

martinhannigan commented 1 year ago

+1

On Fri, Oct 14, 2022 at 10:10 Matt Griswold @.***> wrote:

Good point, thanks!

@peeringdb/pc https://github.com/orgs/peeringdb/teams/pc This should get a priority for release.

— Reply to this email directly, view it on GitHub https://github.com/peeringdb/peeringdb-py/issues/67#issuecomment-1279061881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA2YQXCKWPT2JLJ6F7WGW3WDFSUFANCNFSM55MOE5OQ . You are receiving this because you are on a team that was mentioned.Message ID: @.***>

floatingstatic commented 3 months ago

Just ran into this. +1 for fixing