search

peeringdb / peeringdb

Server code for https://www.peeringdb.com/
BSD 2-Clause "Simplified" License
340 stars 111 forks source link

Mobile Screen Space Recovery #1569

Open martinhannigan opened 2 months ago

martinhannigan commented 2 months ago

Describe the bug

"United States of America" takes up too much screen real estate and negatively impacts mobile users.

To Reproduce

image Expected behavior A clear and concise description of what you expected to happen.

What is the impact?

Screen skew where there are too many bytes in play. Impacts mobile the hardest.

Are there security concerns?

No.

Are there privacy concerns?

No.

What are the proposed actions?

Report results as US or USA uniformly.

What is the proposed priority? simply urgent/not

Medium depending on screen needs particularly for mobile.

Provide a rationale for any/all of the above

Avoid creating long term technical debt and use simple, widely used and common nomenclature.

Additional context

I cant recall the last time myself or colleagues typed, wrote or spoke the entire fully expanded acronym of US or USA in a technical environment and I'm from the US.

leovegoda commented 1 month ago

@martinhannigan Is the full name for the US the only country name that's too long? Looking at the full list there are a handful of medium sized to large countries with similarly long names, plus a bunch of island nations

martinhannigan commented 1 month ago

Leo, I think so. Are we using our own list or are we referencing someone else’s list? If you give me the other list I’ll go look. Thanks.

On Mon, Mar 18, 2024 at 11:26 Leo Vegoda @.***> wrote:

@martinhannigan https://github.com/martinhannigan Is the full name for the US the only country name that's too long? Looking at the full list there are a handful of medium sized to large countries with similarly long names, plus a bunch of island nations

— Reply to this email directly, view it on GitHub https://github.com/peeringdb/peeringdb/issues/1569#issuecomment-2004213378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA2YQVISHYUZUYVV7HPP7DYY4BRBAVCNFSM6AAAAABEWWCVFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGIYTGMZXHA . You are receiving this because you were mentioned.Message ID: @.***>

leovegoda commented 1 month ago

Leo, I think so. Are we using our own list or are we referencing someone else’s list? If you give me the other list I’ll go look. Thanks.

It looks like we are referencing someone else's list because Turkey has changed to Türkiye.

@20c-ed can confirm but we should check if making this change would mean having to hand-manage the list of countries in the future

martinhannigan commented 1 month ago

Thanks. That’s a good point. Hopefully we’re using ISO 3166 (1). If we are and are translating their formal names, I’d suggest the issue would instead become shifting to CC without the country name lookup. Or creating a masking table to over ride where it does waste a lot of screen space.

however, we should also look at Mobile as a special case. As I think more about it, showing a complete PDB UI session on a mobile device seems wasteful. Especially in light of only 20% utilization. I plan to work up another issue that would slim down mobile to slim screen search only which is probably what the 20% is primarily used for.

Tks

On Mon, Mar 18, 2024 at 11:46 Leo Vegoda @.***> wrote:

Leo, I think so. Are we using our own list or are we referencing someone else’s list? If you give me the other list I’ll go look. Thanks.

It looks like we are referencing someone else's list because Turkey has changed to Türkiye.

@20c-ed https://github.com/20c-ed can confirm but we should check if making this change would mean having to hand-manage the list of countries in the future

— Reply to this email directly, view it on GitHub https://github.com/peeringdb/peeringdb/issues/1569#issuecomment-2004274636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA2YQRWO2PPRXGMQOPZVE3YY4D4PAVCNFSM6AAAAABEWWCVFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGI3TINRTGY . You are receiving this because you were mentioned.Message ID: @.***>

grizz commented 1 month ago

It's from a third party https://pypi.org/project/django-countries/

+1 for replacing with ISO 3166-1 alpha 2 everywhere

martinhannigan commented 1 month ago

+1

On Wed, Mar 20, 2024 at 10:41 Matt Griswold @.***> wrote:

It's from a third party https://pypi.org/project/django-countries/

+1 for replacing with ISO 3166-1 alpha 2 everywhere

— Reply to this email directly, view it on GitHub https://github.com/peeringdb/peeringdb/issues/1569#issuecomment-2009735167, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFA2YQX3XRZRIQDOWIQ4PSLYZGNYJAVCNFSM6AAAAABEWWCVFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZG4ZTKMJWG4 . You are receiving this because you were mentioned.Message ID: @.***>