search

peeringdb / peeringdb

Server code for https://www.peeringdb.com/
BSD 2-Clause "Simplified" License
340 stars 111 forks source link

IX-F importer fails on nulled if_speed & pdb_facility_id properties in if_list entries #1602

Open ccaputo opened 3 weeks ago

ccaputo commented 3 weeks ago

Describe the bug Currently the importer will raise an error when encountering null values for if_speed & pdb_facility_id properties in if_list entries.

Expected behavior Even those these null values are arguably out of spec with respect to https://github.com/euro-ix/json-schemas/blob/master/ixp-member-list.schema.json, the robustness principle suggests we should handle this by treating it the same way as if the property (if_speed or pdb_facility_id) was not there at all. (just like we did with https://github.com/peeringdb/peeringdb/issues/1244)

This same principle should apply to other optional properties, so a check for others should be made.

Are there security concerns?

no

Are there privacy concerns?

no

arnoldnipper commented 3 weeks ago

+1, although not a bug on our end. Is it urgent, @ccaputo?

ccaputo commented 3 weeks ago

Is it urgent, @ccaputo?

Nope. Thx.