peerlibrary / meteor-computed-field

Reactively computed field for Meteor
https://atmospherejs.com/peerlibrary/computed-field
BSD 3-Clause "New" or "Revised" License
18 stars 6 forks source link

correct handle being null on meteor 1.1 issue #8

Closed nerdmed closed 9 years ago

nerdmed commented 9 years ago

Hi @mitar thanks again for your suggestion to use this package. I think its very valuable and i am using it very frequently now. I am using a nested Tracker and field computations inside to handle some complex situations and it works very well but i am getting a strange error where the handle in the onStop callback seems to be null when calling the originalStop function. I just added a check into the line. I dont know the consequenses. Would be great to hear something about this.

Cheers Med

mitar commented 9 years ago

Hm, is this something which is happening to you regularly? Always?

mitar commented 9 years ago

Thanks. I implemented a simpler version.

nerdmed commented 9 years ago

Hi @mitar. I will try this out looks promising.

nerdmed commented 9 years ago

@mitar thanks a lot. new release works perfect! And it was happening regularly. I think cause i had nested tracker and some tricky stuff :8ball:

mitar commented 9 years ago

Do you maybe have an example code? So that I could include it into a test?

nerdmed commented 9 years ago

@mitar i will try to create one - mom

nerdmed commented 9 years ago

puh - i cant isolate the error so easily. I am pretty sure its only meteor 1.1.0.3 specific and the extra check should be just enough. The error was also not affecting the functionality. It was only logging. Seemed like for whatever reason the function got called twice.