search

peerlibrary / node-xml4js

XML to JavaScript parser using XML Schema to guide conversion
BSD 3-Clause "New" or "Revised" License
60 stars 11 forks source link

reference to xml2js via git instead of https #3

Closed dotob closed 9 years ago

dotob commented 9 years ago

hi, please make the dependency to xml2js as a https reference. behind a corporate firewall with proxy i cannot successfully download.

mitar commented 9 years ago

Can you explain a bit more what exactly would you like/need?

mitar commented 9 years ago

In title you are saying "instead of https", in description "as a https"? Which one now?

dotob commented 9 years ago

i could fix it with: git config --global url."https://".insteadOf git://

but what i mean is this part in package.json:

"dependencies": {
    "xml2js": "git://github.com/peerlibrary/node-xml2js.git#peerlibrary",

it would be easier for user behind a proxy/firewall if you would use:

"dependencies": {
    "xml2js": "https://github.com/peerlibrary/node-xml2js.git#peerlibrary",
dotob commented 9 years ago

sorry for the bad title :-(

mitar commented 9 years ago

Can you make a pull request?

mitar commented 9 years ago

Fixed with #4.

dotob commented 9 years ago

thanks very much