peerplays-network / getscatter-walletpack

2 stars 2 forks source link

(XS) Proper Peerplays Connection Support #11

Closed MuffinLightning closed 4 years ago

MuffinLightning commented 4 years ago

User Story

Add functionality such that Scatter wallet, when using the Peeprlays plugin, may connect to the peerplays blockchain. Must use either:

Impacts

Describe which portion(s) of Peerplays that may be impacted by your request. Please tick at least one box.

Additional Context (optional)

Explore the necessity of the peerplaysjs-lib websocket connectivity method prior to completing the Peerplays Scatter plugin.

Community / PBSA check list

mseaward commented 4 years ago

I am exploring in depth as to whether or not we will require the peerplaysjs-lib websocket connectivity. Thus far, I am inclined to say that it is not necessary. Will update ticket once a conclusion has been made on the details.

mseaward commented 4 years ago

18 after investigation, @MuffinLightning and I are pretty sure that CORS will not be an issue in production mode of the scatter wallet. Thus, we will proceed with a fetch based approach to retrieving data and continue to develop via unit tests as per instruction from Nathan

mseaward commented 4 years ago

Closing as this issue initially outlined the instantiation of a websocket connection that once completed, would complete this story. However, we are going to proceed with fetch based calls which means there will be no constant connection to a Peerplays blockchain API node thereby removing the need for this issue.