Fix memory leak. Not all tasks are deleted in thread_d dtor

peerplays-network / peerplays-fc

Peerplays Fast Compile Library

6 stars 1 forks source link

Fix memory leak. Not all tasks are deleted in thread_d dtor #8

Closed srpatel19590 closed 4 years ago

srpatel19590 commented 4 years ago

In thread::quit() { ... my->start_next_fiber(true) ... } my->start_next_fiber(true) - an exception is raised from here and a context has yet a pointer to the task that will never released and memory will not freed. So to avoid such situation in ~thread_d() lets release it.

Reference: https://github.com/bitshares/bitshares-fc/pull/130

srpatel19590 commented 4 years ago

@oxarbitrage I've been instructed to raise PR in latest-fc. @pbattu123 please share the FC Gitflow

pbattu123 commented 4 years ago

Unsure if latest-fc is the branch we want to merge this or just directly master. Please explain briefly for the record the FC flow.

Code looks good.

Git flow for fc:

Any updates would go into latest-fc branch as there might be a relevant code changes on develop. Develop(fc submodule) branch would always point to latest-fc.
During the testnet/mainnet releases, fc/latest-fc branch would be merged with fc/develop and Devops guy will push the changes to master.

oxarbitrage commented 4 years ago

Thank you @pbattu123