search

peers / peerjs-server

Server for PeerJS
https://peerjs.com
MIT License
4.37k stars 1.09k forks source link

Possibility of custom emitted events #283

Open sergeyyurkov1 opened 2 years ago

sergeyyurkov1 commented 2 years ago

I have a suggestion:

Because Peer.js server uses sockets under the hood for signalling, it would be great to have the ability to tap into the existing channel and emit custom events that could be accepted on the client side and vice versa (unless I'm missing something and this is already possible). I tried to experiment with EventEmitter's newListener()/addListener() but to no avail (please pardon my inexperience). That would be useful for, say, room management and eliminate the need for opening a second connection (sockets or HTTP) for this sort of thing.

Example: peerServer.emit("test", ...) on the server side -> peer.on("test", ...) on the client.

Thank you.

jonasgloning commented 2 years ago

Hey @sergeyyurkov1, thanks for the request. I’ll put in on the roadmap :)

vijayabhaskar-ev commented 7 months ago

Hey @jonasgloning ,Can I take up this feature as i recently worked on implementing custom events in the modified version of the peerjs

jonasgloning commented 7 months ago

Yes, please!

You can ping @peers/maintainers if you need some help or want some feedback on the way.

But to dampen expectations: our review times are pretty bad right now, so it might take some time to merge your proposal.

vijayabhaskar-ev commented 5 months ago

@jonasgloning @sergeyyurkov1 @irgalamarr @igrigorik I need some clarification. The user should be able to emit and listen from both server side and client side. Right? And also should i write my own wrapper for custom events using web socket or can we consider using socket.io?