Closed Pacific112 closed 5 years ago
Can confirm, tried peerjs on Ionic 4 (which i assume running Angular 6) with the same import method
Have the same problem using Webpack and CreateReactApp. Seems to be a new problem introduced in 0.3.20 or 0.3.19.
I'm working on it, anyway any PR is welcome
Thanks @kidandcat ! I'd love to help, but I have no experience with TypeScript. Version 0.3.18 works fine, so no worries.
Same here, using vue-cli
Fixed in peerjs@0.3.22
@kidandcat tried with 0.3.22 and 1.0.0 in Angular 7, this issue is still seen.
How are you importing it
How are you importing it
Few:
import * as Peer from 'peerjs'
-> this one was complied successfully, however error was thrown same like in first comment
import { Peer } from 'peerjs'
and import Peer from 'peerjs'
-> these two caused compile error
I only install peerjs
package, don't use @type/peerjs
since index.d.ts is already available in peerjs
package.
@kidandcat I was able to resolve my issue by enabling following flag in tsconfig.json file
{
...
"esModuleInterop": true,
...
}
@nhducseuit what is the context did you use?
I have this problem with ionic 4.
"@angular/common": "^7.2.2", "@angular/core": "^7.2.2", "@angular/forms": "^7.2.2", "@angular/http": "^7.2.2", "@angular/platform-browser": "^7.2.2", "@angular/platform-browser-dynamic": "^7.2.2", "@angular/router": "^7.2.2", "@ionic-native/core": "^5.0.0", "@ionic-native/splash-screen": "^5.0.0", "@ionic-native/status-bar": "^5.0.0", "@ionic/angular": "^4.1.0", "buffer": "^5.2.1", "core-js": "^2.5.4", "peerjs": "^1.0.2",
What I can do?
@kidandcat I was able to resolve my issue by enabling following flag in tsconfig.json file
{ ... "esModuleInterop": true, ... }
Does this have any impact on anything else? Could it break other things. The documentation on typescript says something that is not really understandbble. What does this esModuleInterop option actually do .Because we dont want to break other things. https://www.typescriptlang.org/docs/handbook/compiler-options.html
Issue #479 is still present. I am using version 0.3.20 of peerjs. To reproduce:
ng new app
npm install --save peerjs
ERROR TypeError: peerjs__WEBPACK_IMPORTED_MODULE_2__ is not a constructor