peeter123 / digikey-api

Python module for the Digikey PartSearch API
GNU General Public License v3.0
85 stars 35 forks source link

Add configuration storage class. Made DigikeyAPI into a class #15

Open Electro707 opened 3 years ago

Electro707 commented 3 years ago

This PR adds a method of setting and saving this package's settings (like client-id and refresh-token) without needing to use OS environment variables. Main changes includes:

TODO:

eeintech commented 3 years ago

This is an interesting proposition and I hope to see this being merged.

@peeter123 Any plan to review this soon?

@Electro707 Do you need help with testing?

Electro707 commented 3 years ago

@eeintech Sure, just beware that A) This is not too well documented which is something I need to do, and B) Only works with V3 API. @peeter123 Is it even worth it to add support to v2 even tough it's deprecated by Digikey, or is it time to drop V2 support?

Electro707 commented 3 years ago

@peeter123 Any thoughts on the V2 API, if I should add this new config class to it or if it should be deprecated?

peeter123 commented 2 years ago

I will look into this, I think we can make a 1.0 version where we drop the V2 API completely. What do you think?

peeter123 commented 2 years ago

Could you rebase on development-1.0 branch in peeter123/digikey-api?

Electro707 commented 2 years ago

Rebasing is done.