peev / cryptobeast-reactjs

MIT License
1 stars 2 forks source link

Login side cases issues #309

Closed TeodorKolev closed 5 years ago

TeodorKolev commented 5 years ago
  1. Delete selected_portfolio_id from LocalStorage and reload page: Expected: webpage load with err message "Please use valid external link" Actual: crash

  2. Cover cases where addresses form params are new portfolio addresses, but selected_portfolio_id respond to previously selected portfolio.

  3. Fetch should load just once. There shouldn't be any repeating requests for example: /portfolio/history/1

  4. Do we add new addresses from params in LocalStorage or replace it with them?

Test cases: ('/') no params, no addresses, no selected id - Please use valid external link no params, multi addresses, no selected id - Select portfolio no params, multi addresses, not existing id (12345) - Select portfolio no params, multi addresses, null id - Select portfolio multi params, no addresses, no selected id - Select portfolio multi params, no addresses, null id - Select portfolio single param, multi addresses, no selected id - Login single param, no addresses, no selected id - Login single param, no addresses, not existing id (12345) - Login single param, no addresses, null id - Login ('/summary') multi addresses, no selected id - Select portfolio multi addresses, not existing id (12345) - Select portfolio single addresses, not existing id (12345) - Login single addresses, null id (12345) - Sync and Login no addresses, selected id - Please use valid external link no addresses, no id - Please use valid external link