search

pegasystems / constellation-ui-gallery

This open-source repository provides a collection of ready-to-use and customizable Constellation DX components. Use this resource to gain inspiration, best practices, and a solid foundation for implementing custom components.
https://pegasystems.github.io/constellation-ui-gallery/
Apache License 2.0
30 stars 22 forks source link

UtilityList code review #12

Closed vijayjangid closed 7 months ago

vijayjangid commented 7 months ago

Missing effect dependency: secondaryFieldTypes should be added as dependency. The list is not updating when field types are changed alone. https://github.com/pegasystems/constellation-ui-gallery/blob/f203893174502de6a8be6c93bb0dfdcd83d170d7/src/components/Pega_Extensions_UtilityList/index.tsx#L109

Redundent check: item.pxObjClass && item.pyID can be removed https://github.com/pegasystems/constellation-ui-gallery/blob/f203893174502de6a8be6c93bb0dfdcd83d170d7/src/components/Pega_Extensions_UtilityList/utils.tsx#L21

HeadingTag should be used "h3" for utility summary lists we are using h3 in other places (Attachments, Stakeholders etc). Consider passing prop headingTag='h3' https://github.com/pegasystems/constellation-ui-gallery/blob/f203893174502de6a8be6c93bb0dfdcd83d170d7/src/components/Pega_Extensions_UtilityList/index.tsx#L115

ricmars commented 7 months ago

changes approved and merged https://github.com/pegasystems/constellation-ui-gallery/commit/49c039e216c319f89a5735f3133779209723293b