search

pegasystems / pega-alertanalyzer

AlertAnalyzer is a tool that can be used to analyze PegaRULES ALert log files and render insights into performance issues
Apache License 2.0
11 stars 5 forks source link

Is this supposed to output a war file? #4

Closed cdancy closed 6 years ago

cdancy commented 6 years ago

Project has been converted to gradle with the stub provided by gradle-multi-project-example. I noticed a WebContent directory containing various web related files and was wondering what was up and/or what this is?

Also ... take a look at the new structure and let me know what you think.

EDIT: it should be noted that VERY aggressive checking is enabled for the attached static analysis tools and as such this code, as it is now, is in pretty rough shape.

dcasavant commented 6 years ago

The CI pipeline is currently failing as well.

@cdancy Why is it that we are getting an error tag from Travis-CI on failure? Is that a misconfig on my end? Shouldn't it be a failure tag?

cdancy commented 6 years ago

@dcasavant this is a "feature" of travis for better or worse :) Just added a change to the travis file to side-step this feature and get an actual fail.

feenr commented 6 years ago

@cdancy saw that you enabled a few static analysis tools, but they are all failing miserably. I started working through the checkstyle warnings. https://github.com/feenr/pega-alertanalyzer

Were you able to generate the war file, even if it's not part of the build script yet?

Would you be willing to remove those static analysis tasks from the Travis scripts and track them individually as issues, just so it has a passing build?

cdancy commented 6 years ago

Yeah I left these in place so that folks working on this project, whenever they eventually got around to it, would be forced to clean up the code base so that individuals stumbling upon this project on the internets would not think we are churning out un-production level code.

As for removing these checks you can simply comment out the relevant lines in the gradle/projects.gradle file that you don't want it to check for.

    apply from: "$rootDir/gradle/jacoco.gradle"
    // apply from: "$rootDir/gradle/pmd.gradle"
    apply from: "$rootDir/gradle/checkstyle.gradle"
    //apply from: "$rootDir/gradle/findbugs.gradle"