pegasystems / pega-datascientist-tools

Pega Data Scientist Tools
https://github.com/pegasystems/pega-datascientist-tools/wiki
Apache License 2.0
33 stars 24 forks source link

Install fails due to "pROC" dependency #186

Closed AntonTal closed 8 months ago

AntonTal commented 8 months ago

pdstools version checks

Issue description

Installing pdstools with "build_vignettes=TRUE" requires the "pROC" library to be preinstalled, so when running "install_github("pegasystems/pega-datascientist-tools/r", build_vignettes=TRUE)" on a clean system fails the instalment. Seemingly the pROC is used in "adm-explained" notebook. See the error log:

Screenshot 2024-01-11 at 09 48 28

Reproducible example

Run "install_github("pegasystems/pega-datascientist-tools/r", build_vignettes=TRUE)" without pROC library pre-installed.

Expected behavior

"install_github("pegasystems/pega-datascientist-tools/r", build_vignettes=TRUE)" should run without failure

operdeck commented 8 months ago

Hey Anton, thanks, I'll move pROC from suggested to required imports in the R library.

BTW note that the python version is more actively being maintained these days than the R one.