pegasystems / pega-datascientist-tools

Pega Data Scientist Tools
https://github.com/pegasystems/pega-datascientist-tools/wiki
Apache License 2.0
33 stars 24 forks source link

Make regex strings raw strings #232

Closed StijnKas closed 2 months ago

StijnKas commented 2 months ago

I was running into warnings on our regexes:

[/Users/kass1/Documents/pdstools/.venv/lib/python3.12/site-packages/pdstools/adm/ADMDatamart.py:1301](https://file+.vscode-resource.vscode-cdn.net/Users/kass1/Documents/pdstools/.venv/lib/python3.12/site-packages/pdstools/adm/ADMDatamart.py:1301): SyntaxWarning: invalid escape sequence '\-'
  return pl.col(x).str.replace_all("[ \-_]", "").str.to_uppercase()
[/Users/kass1/Documents/pdstools/.venv/lib/python3.12/site-packages/pdstools/pega_io/File.py:339](https://file+.vscode-resource.vscode-cdn.net/Users/kass1/Documents/pdstools/.venv/lib/python3.12/site-packages/pdstools/pega_io/File.py:339): SyntaxWarning: invalid escape sequence '\d'
  return fromPRPCDateTime(re.search("\d.*GMT", x)[0].replace("_", " "))

Fixed this by turning these strings into raw strings

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.59%. Comparing base (d6cc0c5) to head (5f1e122).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ======================================= Coverage 59.59% 59.59% ======================================= Files 29 29 Lines 3789 3789 ======================================= Hits 2258 2258 Misses 1531 1531 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.