pegasystems / pega-datascientist-tools

Pega Data Scientist Tools
https://github.com/pegasystems/pega-datascientist-tools/wiki
Apache License 2.0
33 stars 24 forks source link

Generate Report Refactor #253

Closed yusufuyanik1 closed 2 weeks ago

yusufuyanik1 commented 3 weeks ago

Refactor health check and model report generation functions

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 12.12121% with 58 lines in your changes missing coverage. Please review.

Project coverage is 59.09%. Comparing base (2d5667e) to head (5e30124). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
python/pdstools/adm/ADMDatamart.py 2.17% 45 Missing :warning:
python/pdstools/utils/cdh_utils.py 36.84% 12 Missing :warning:
python/pdstools/plots/plot_base.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #253 +/- ## ========================================== - Coverage 59.30% 59.09% -0.21% ========================================== Files 29 29 Lines 3863 3885 +22 ========================================== + Hits 2291 2296 +5 - Misses 1572 1589 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yusufuyanik1 commented 2 weeks ago

Thanks for the review @StijnKas. I believe I've addressed your comments. Could you please review them again when you have time?