pegasystems / pega-datascientist-tools

Pega Data Scientist Tools
https://github.com/pegasystems/pega-datascientist-tools/wiki
Apache License 2.0
33 stars 24 forks source link

Small fry for ADM explained article #95

Closed operdeck closed 3 months ago

operdeck commented 1 year ago

pdstools version checks

Issue description

looking at https://pegasystems.github.io/pega-datascientist-tools/Python/articles/ADMExplained.html and comparing to https://pegasystems.github.io/pega-datascientist-tools/R/articles/adm-explained.html

The order of the fields is different but the python version is preferable (sorted)

Reproducible example

See python doc

Expected behavior

At par with R version

Installed versions

``` Replace this line with the output of pdstools.show_versions(), leave the backticks in place ```
yusufuyanik1 commented 1 year ago

Updated with the points you mentioned.

operdeck commented 1 year ago

Cool. I can't see it in the article because that only gets republished with a new version?

Op di 23 mei 2023 om 18:10 schreef yusufuyanik1 @.***>:

Updated https://pegasystems.github.io/pega-datascientist-tools/Python/articles/ADMExplained.html with the points you mentioned.

— Reply to this email directly, view it on GitHub https://github.com/pegasystems/pega-datascientist-tools/issues/95#issuecomment-1559748913, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEVTKGZLAENECNPSKLSD7DXHTONTANCNFSM6AAAAAAYKGW6WA . You are receiving this because you authored the thread.Message ID: @.***>

StijnKas commented 1 year ago

The article should be fully in sync with whatever's there in the repo, it's not tied to any versions. Let's check tomorrow.

operdeck commented 1 year ago

R version changed with better formulae and selected a different predictor, one with AUC < the model itself

StijnKas commented 10 months ago

@operdeck @yusufuyanik1 just a check - have we fixed this one?

yusufuyanik1 commented 10 months ago

@StijnKas Yes, we aligned them