pegasystems / pega-helm-charts

Orchestrate a Pega Platform™ deployment by using Docker, Kubernetes, and Helm to take advantage of Pega Platform Cloud Choice flexibility.
https://community.pega.com/knowledgebase/articles/cloud-choice
Apache License 2.0
123 stars 194 forks source link

Consistent labels across all workloads #590

Closed brettcurtis closed 1 month ago

brettcurtis commented 1 year ago

Howdy! We are trying to configure Unified Service Tagging across all our Pega workloads.

The problem is there is not a consistent way of doing this in the chart unless I'm misunderstanding this PR: https://github.com/pegasystems/pega-helm-charts/pull/470? This doesn't work in my use case because I need a different label for each workload.

I need to be able to label each workload as well as the Pods. Currently I'm able to label the pods with: global.tier[0].podLabels

Search doesn't have support for labels so the best I have there is: pegasearch.custom.env[1].name but this just adds a variable to the container when again I really want the workload and PODs labeled.

Is this a resonable request or is a W/A available that can help me achieve what I'm after?

johnbooth commented 10 months ago

We are having the same issue with the externalized hazelcast, pega-hazelcast. This service doesn't even support custom environment variables.

hazelcast.custom.env[1].name

kishorv10 commented 4 months ago

@brettcurtis podLabels feature is available on the search sub-chart as well. Ref #709 Do you have any more asks from this issue?

brettcurtis commented 4 months ago

Howdy !

We need to be able to set the following on:

metadata.labels spec.template.metadata.labels spec.template.metadata.annotations

Let me know if you need anything else.

kishorv10 commented 4 months ago

Please see if the below configuration helps, metadata.labels - .root.Values.global.pegaTier.labels - The same set of labels would be applied to all the deployments. Available for Pega deployments only. Not available for pega-search deployment. spec.template.metadata.labels - tier[].podLabels - Tier specific pod labels. Available for pega-search as well spec.template.metadata.annotations - tier[].podAnnotation - Tier specific pod annotations. Available for pega-search as well

Can you try and revert?

The gaps are,

  1. Unable to specify tier-specific labels to deployment objects.
  2. Unable to specify deployment labels for pega-search.

Since most of the requirements are now supported, are you able to achieve what you're looking for? Do you have specific use cases for the two remaining gaps?

brettcurtis commented 4 months ago

Let me take a look and potentially test today but I do know we will need all I mentioned above to get the correct association in Datadog so if there are still gaps we will be unsuccessful.

github-actions[bot] commented 1 month ago

This issue has been marked as stale because it has been open for 60 days with no activity. This issue will be automatically closed in 30 days if no further activity occurs.

brettcurtis commented 1 month ago

I'll test this next week and report back.

brettcurtis commented 1 month ago

Closing this since the only services that need to handle labels better now are services that will soon be externalized.