search

pegasystems / pega-helm-charts

Orchestrate a Pega Platform™ deployment by using Docker, Kubernetes, and Helm to take advantage of Pega Platform Cloud Choice flexibility.
https://docs.pega.com/bundle/platform/page/platform/deployment/client-managed-cloud/containerized-deployments-kubernetes.html
Apache License 2.0
127 stars 201 forks source link

pega-tomcat-keystore-secret.yaml still generated if external secret is provided #812

Open rob8714 opened 1 month ago

rob8714 commented 1 month ago

Describe the bug The pega-tomcat-keystore-secret.yaml is producing output even if an external secret is provided.

To Reproduce Set the following for the tiers in the values file and generate the helm chart:

service:
  tls:
    enabled: true
    external_secret_names: ["test"]

Expected behavior When external_secret_names is not empty, the pega-tomcat-keystore-secret.yaml content should not be generated.

Chart version v3.24.3

Additional context Potentially this was broken with https://github.com/pegasystems/pega-helm-charts/commit/7d03c0fa8e26b2b5d32f62e2e0baca16e503b236. With this commit there was a change in name from external_secret_name to external_secret_names. In pega-tomcat-keystore-secret.yaml the condition is:

{{ if not (($dep.service).tls).external_secret_name }}