search

peggyjs / peggy

Peggy: Parser generator for JavaScript
https://peggyjs.org/
MIT License
926 stars 65 forks source link

Fix vscode-eslint settings #505

Closed SamB closed 6 months ago

SamB commented 6 months ago

I ran into a few papercuts with peggy.code-workspace:

  1. vscode-eslint wasn't using the settings from eslint.config.js, so I fixed that
  2. the workspace had vscode-eslint set as the default formatter for all languages, so I fixed that
  3. peggy.code-workspace was indented with tabs, but .editorconfig said to use spaces for all files, so I reindented the file

Then, of course, I painstakingly committed each of those changes in the opposite order.

hildjj commented 6 months ago

Shoot, I should have run two more checks before I landed this. @SamB, can you please send another PR that includes:

hildjj commented 3 months ago

@SamB I added you to the AUHTORS file in preparation for 4.0.3. Feel free to send me another pull request with any preferred naming or contact info.