search

peggyjs / peggy

Peggy: Parser generator for JavaScript
https://peggyjs.org/
MIT License
926 stars 65 forks source link

Remove stray semicolon in CSS #507

Closed Flamenco closed 6 months ago

hildjj commented 6 months ago

Please add a changelog entry and ensure you are in the AUTHORS file. Or, I could do a full pass on the CSS file myself and fix this in the process if you'd prefer.

Flamenco commented 6 months ago

Oops. Forgot again. I will update. Thanks.

Flamenco commented 6 months ago

@hildjj I broke up my PR into 3 different ones, so as to not base them off each other. You will have to merge the overlapping CHANGELOG.

hildjj commented 6 months ago

For the overlapping changelog, I'm going to have you rebase each PR before merging.

Flamenco commented 6 months ago

So after you approve all 3, I rebase them. Correct?

hildjj commented 6 months ago

yes. Let's finish the discussion of #509, then tell me what order you want me to apply them.

hildjj commented 6 months ago

Or if it's easier, just combine them into one PR.

Flamenco commented 6 months ago

I think keep them separate.

  1. semicolon
  2. enable text
  3. es6 export