Make numpy optional - Githubissues

pegler / pytzwhere

python library to look up timezone from lat lng offline

Other

146 stars 54 forks source link

Make numpy optional #43

Closed famanson closed 7 years ago

famanson commented 7 years ago

Hi @pegler,

In your last merge, docopt, shapely and numpy are all made into required dependencies rather than optional. While we are okay with docopt and shapely, numpy is a rather heavy dependency and it does not play nicely with our existing codebase in production.

Is there any chance it can be made optional again? (I've done this on our fork anyway as you can see in this PR)

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 71.698% when pulling d9b758d94806b4e97cff0181770bc962e238a858 on esplorio:master into df871d2dfaed96a8d537b0f57f2a6d00fd2bb024 on pegler:master.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 71.698% when pulling 5bab3fd17b61477bd6d48af663fb9cf54bea6ad7 on esplorio:master into df871d2dfaed96a8d537b0f57f2a6d00fd2bb024 on pegler:master.

pegler commented 7 years ago

thanks @famanson! I just pushed v3.0.1 to pypi