search

pegler / pytzwhere

python library to look up timezone from lat lng offline
Other
146 stars 54 forks source link

add json files to MANIFEST.in, remove obsolete .csv file #46

Open seahawk1986 opened 7 years ago

seahawk1986 commented 7 years ago

According to https://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=include_package_data#including-data-files all files that should be installed automatically when using include_package_data=True in setup.py must be included in the MANIFEST.in Also tzwhere/tz_world.csv has been removed in https://github.com/pegler/pytzwhere/commit/df871d2dfaed96a8d537b0f57f2a6d00fd2bb024

This pull request should fix the installation of the missing json files reported in #44 and #45

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 71.698% when pulling a12b522d409583dbe8f16c3ab2072aa18ffeacaf on seahawk1986:fix_install into 633bde38e5e83155ff88f421c80889cd64df2f88 on pegler:master.

linwoodc3 commented 7 years ago

Any news on when this will be merged?

Should add a unit test @seahawk1986 to move his coverage up. Do a local read of the file and just check that it's a valid json.

Note: This file is large; I'm going to do a pull request (starting from @seahawk1986 changes) and pickle/compress this file using standard lib, and have the load function decompress and load locally.

I did the initial code, and the file size is reduced to 27 MB (compared to 90 MB). This would lighten the load of including the file in the pip install.

Rudd-O commented 7 years ago

We need this fixed too. Please merge. Thank you!