search

pegnet / pegnetd

The pegnet daemon to track txs, conversions, etc
Other
13 stars 14 forks source link

Add `get-graded` API method #129

Closed OrmEmbaar closed 4 years ago

OrmEmbaar commented 4 years ago

PR adds a new API method get-graded. Method accepts a single height as a parameter and returns a selection of fields from all graded OPRs for that height from the DB.

OrmEmbaar commented 4 years ago

Thanks for the feedback; I have pushed those requested changes.

PaulBernier commented 4 years ago

LGTM. As there is no automated tests for those API in pegnet apparently, can you confirm that you at least manually tested that new API?

OrmEmbaar commented 4 years ago

LGTM. As there is no automated tests for those API in pegnet apparently, can you confirm that you at least manually tested that new API?

Yes, I have been developing against the endpoint for the past 24 hours.

WhoSoup commented 4 years ago

As there is no automated tests for those API in pegnet apparently, can you confirm that you at least manually tested that new API?

I tested it during my review and can confirm it passes the smoke test.

PaulBernier commented 4 years ago

Thank you for your contribution!