pegnet / pegnetd

The pegnet daemon to track txs, conversions, etc
Other
13 stars 14 forks source link

Eth gateway #87

Closed Emyrk closed 4 years ago

Emyrk commented 4 years ago

This code enables rcd-e valid at an activation height (currently tbd). It also updates the dependencies of /factom lib to use the latest fat refactor. The refactor changed a lot of method signatures, and solved some of the issues we had hotfixes for before, such as the random timestamps.

WhoSoup commented 4 years ago

sidenote for any other reviewers: this branch works in tandem with changes to the factom client, located in https://github.com/Emyrk/factom/tree/rcd_full

Emyrk commented 4 years ago

@WhoSoup This PR is updated and ready

WhoSoup commented 4 years ago

I don't think this feature will be used all that often?? It's kinda a power user feature given it crosses blockchains.

that really depends on the success of the gateway. if erc20 adoption is a massive success, the Fe addresses could become the de facto standard. that said, this has always been a stopgap measure until factom supports rcd-e. i'd rather see the effort put into accomplishing that than reworking this

Emyrk commented 4 years ago

I don't think this feature will be used all that often?? It's kinda a power user feature given it crosses blockchains.

that really depends on the success of the gateway. if erc20 adoption is a massive success, the Fe addresses could become the de facto standard. that said, this has always been a stopgap measure until factom supports rcd-e. i'd rather see the effort put into accomplishing that than reworking this

Yes once Factom adopts rcd-e, we will drop Fe entirely. As it would no longer be needed.