Closed mberry closed 4 years ago
@MitchellBerry It looks like running the unit tests and gofmt were removed? Does this push an image to dockerhub?
I also changed your base to develop
You are correct, I stripped it all back and forgot to reinstate gofmt and tests.
Thought services:docker was put in for xgo and unnecessary for deploying to the releases page, I'll look into dockerhub, didn't realise it was also shipping there.
Thinking I will close and resubmit this PR to test docker out so as to not spam the place up with commits.
Able to get this deploying on my end with tagged commits. Updated a few deprecated fields as travis has changed a few things around.
A test tag for upstream is still necessary to check it will add the binaries to the releases page. So a
git tag v0.3.0.deploy-test
or something of that nature.