search

pehvbot / LRTR

Kerbal Space Program - Less Real Than Real
6 stars 3 forks source link

Multiple issues with Procedural Parts integration. #2

Closed drhead closed 2 years ago

drhead commented 2 years ago

In LRTR/support/proceduralparts.cfg, the lines for adding upgrades to the tech tree have the following conditions:

PARTUPGRADE:NEEDS[LRTRTechTree,ProceduralPart]

The mod is called ProceduralParts, so this will never satisfy its needs in ModuleManager and will therefore never load. Correcting this allows some of them to load correctly. However, most still won't load correctly because the tech node names are completely wrong. For example, Procedural Tank min diameter 0.625 lists its required tech as earlyMaterialsScience, but Early Materials Science is referred to as engineering101 internally. The needed changes (assuming the "lrtr" lines reflect the intended node) are:

earlyMaterialsScience -> engineering101 materialsScienceHuman -> generalConstruction materialsScienceLunar -> fuelSystems materialsScienceSpaceStation -> specializedConstruction materialsScienceSpaceplanes -> advFuelSystems lifeSupportISRU -> basicLifeSupport experimentalScience -> longTermLifeSupport (?) -- ore tanks seem out of place under Experimental Science, when the largest ore tanks are here electronicsLunar -> miniaturization aerodynamicSystems -> supersonicFlightRP0, hypersonicFlightRP0 (consecutively) effectiveSpaceplanes -> aerodynamicSystems humanRatedEDL -> flightControl earlyLanding -> landing advancedLanding -> advUnmanned

Finally, many of the upgrades have no in-game description of what they do (particularly the SRB upgrades), perhaps this should be corrected.

I have confirmed that these changes make all of the upgrades show up and have attached a modified file for fixing this: proceduralparts.txt

(rename it back to .cfg since github doesn't allow .cfgs as attachments)

pehvbot commented 2 years ago

Thanks! Your changes look great. I have no idea how the ProceduralPart vs Parts even got that far. I assume I tested this patch at some point. I'm guessing I added it in with a careless global search and replace.

The techRequired issues happened in the latest update because I changed the tech tree from a purely RP-1 (with no overlap with the stock tree) to one where the stock tree was embedded into the RP-1 tree. I missed updating this cfg file so it was still using the RP-1 tree.

I really appreciate the work fixing this. I'll clean it up a little bit more by making all the tech node names match the upgrade names but otherwise add it in as is.