peilinye / pe

0 stars 0 forks source link

Candidate can go for interview for position not signed up for #4

Open peilinye opened 2 years ago

peilinye commented 2 years ago

Screenshot 2021-11-12 at 4.38.24 PM.png

Alex Yeoh (candidate 1) applied for the position 'Bookkeeper' but can be assigned to 'Admin Assistant' interview (third interview in the list). Could mess up the app if a lot of data like this is invalid. Done by editing the JSON file, JSON file does not check validity in this area.

This should be considered an invalid editing to the JSON file, as it would not normally be allowed. Screenshot 2021-11-12 at 4.51.52 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Vast majority of users will not edit JSON, UG specifically warned against editing JSON

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This would actually cause a rather big problem in the context of this application, since it is supposed to keep track of candidates and their positions and interviews. If such erroneous information from the JSON is not checked and actually allowed by the application, this could mess up the application quite significantly with corrupted data. There should hence be validity checking in this area, and the data should be flushed out as per the requirements in the screenshot below. In the worst case, the app could be filled with so much wrong data that it becomes extremely difficult to use for the target users. Hence, this warrants a Medium severity level in my opinion.

Screenshot 2021-11-17 at 3.03.23 PM.png