search

peilinye / pe

0 stars 0 forks source link

Interview name could be random #6

Open peilinye opened 2 years ago

peilinye commented 2 years ago

Screenshot 2021-11-12 at 4.53.25 PM.png

No position called 'Hello' exists but the JSON file can be edited such that interview for 'Hello' exists, and candidates can be assigned to it (in JSON). No validity checking of the JSON file in this area and could potentially mess up/corrupt the app data.

Screenshot 2021-11-12 at 4.57.15 PM.png On using the app to try to assign, it's a failure (as expected).

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Candidate can go for interview for position not signed up for

Screenshot 2021-11-12 at 4.38.24 PM.png

Alex Yeoh (candidate 1) applied for the position 'Bookkeeper' but can be assigned to 'Admin Assistant' interview (third interview in the list). Could mess up the app if a lot of data like this is invalid. Done by editing the JSON file, JSON file does not check validity in this area.

This should be considered an invalid editing to the JSON file, as it would not normally be allowed. Screenshot 2021-11-12 at 4.51.52 PM.png

[original: nus-cs2103-AY2122S1/pe-interim#4994] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Vast majority of users will not edit JSON, UG specifically warned against editing JSON

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Both are caused by editing the JSON file, but the error comes from different causes. The validity checkings required to solve these 2 problems are also different.

The first problem is that candidates registered for an interview of a particular position could actually not have applied to that position (eg. Alice could be under Accountant interview, but she did not apply for the Accoutant position), while the second problem is that random interviews could exist in the application despite there not being a position of that name (eg. there could be an interview for Accountant when the Accountant position does not exist).

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]