search

peilun-he / PDSim

Web application for the polynomial diffuison model
Apache License 2.0
0 stars 1 forks source link

Should be "cannot" and "any" should be removed. Better would be to cite an existing definition of the no-arbitrage condition. #17

Closed peilun-he closed 5 months ago

peilun-he commented 6 months ago

A citation of definition is added

taqtiqa-mark commented 6 months ago

Can you cite this issue in the relevant PR, or link to the commit where you say this has been fixed?

peilun-he commented 5 months ago

Please see: https://github.com/peilun-he/PDSim/commit/bc98404f58956a39ccb067dfc89da80fc86cd74c

taqtiqa-mark commented 5 months ago

I've added my comment/suggestion to that commit. It is not showing up likely due to a PR workflow not being used?

I'll track as a separate issue.

taqtiqa-mark commented 5 months ago

Happy for this issue to be closed.