Issue #124. - Githubissues

peimanja / artifactory_exporter

JFrog Artifactory Prometheus Exporter written in Go

Apache License 2.0

140 stars 37 forks source link

Closed KacperPerschke closed 4 months ago

KacperPerschke commented 4 months ago

An attempt to clean up systematize the code that converts Artifactory strings to numbers accepted in Prometheus.

I need to write unit tests for a converter.
Change of call removeCommas to convNumArtiToProm should be deeply investigated.
May the percentage be the solution to #126?

KacperPerschke commented 4 months ago

sonarcloud[bot] commented 4 months ago

peimanja commented 4 months ago

perfect @KacperPerschke. Need to do a few comparison but we can get the canary out to try