search

peimanja / artifactory_exporter

JFrog Artifactory Prometheus Exporter written in Go
Apache License 2.0
141 stars 37 forks source link

Add support for exporting any users #49

Closed lbpdt closed 3 years ago

lbpdt commented 3 years ago

Instead of enumerating the types of users, how about dynamically creating metrics based of the realms that exist on the instance? For example, http-sso is another user realm that is currently not supported.

There is a breaking change in this implementation though: user realms containing no users will no longer publish a 0 metric, but dashboards can default to 0 if data is missing so it feels reasonable.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lbpdt commented 3 years ago

Great! And thank you for the quick review & release 👍