search

peimanja / artifactory_exporter

JFrog Artifactory Prometheus Exporter written in Go
Apache License 2.0
141 stars 37 forks source link

Wrong license endpoint #64

Closed martinm82 closed 2 years ago

martinm82 commented 2 years ago

Overview of the Issue

Based on https://www.jfrog.com/confluence/display/JFROG/Artifactory+REST+API#ArtifactoryRESTAPI-LicenseInformation the license endpoint is called licenses and not license as defined here: https://github.com/peimanja/artifactory_exporter/blob/master/artifactory/system.go#L12

At least this is for Artifactory 7.x. Maybe it was like that in 6.x

Reproduction Steps

Operating system and Environment details

Logs

Log output of exporter when running and you try to get metrics from the metric path.

peimanja commented 2 years ago

Thanks @martinm82, we are also on version 7.x and I just confirmed both license and licences endpoints exists. maybe they kept it for backward compatibility. So I'm going to leave this as it is in case we break things for people on 6.x version