search

peimanja / artifactory_exporter

JFrog Artifactory Prometheus Exporter written in Go
Apache License 2.0
141 stars 37 forks source link

Upgrade from Go 1.17 to 1.18 #85

Closed lbpdt closed 1 year ago

lbpdt commented 1 year ago

Also upgrade golang.org/x/sys dependency to solve a build issue on Go 1.18 - see https://stackoverflow.com/a/71508032.

We are using this project from nixpkgs, which is failing to build it with more recent versions of Go. Would be great to cut a new release once this is merged - thanks!

peimanja commented 1 year ago

@lbpdt Thanks for the contribution. Let's also update the go version in the binary release workflow here

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lbpdt commented 1 year ago

@lbpdt Thanks for the contribution. Let's also update the go version in the binary release workflow here

Forgot to grep over hidden folders - fixed!

peimanja commented 1 year ago

@lbpdt Please check the image with canary or latest tag and report back if everything is working and I will publish a new release otherwise I will do some testing in a few days

lbpdt commented 1 year ago

I was able to test the latest image tag successfully 👍

lbpdt commented 1 year ago

Thanks for the quick review & release!