search

peircej / jbrout

Automatically exported from code.google.com/p/jbrout
0 stars 0 forks source link

Download plugin improvements #155

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I was going to start writing a plug-in to import photos, when I realized that 
there was already one available ;)
The problem was that it was not working at first, and then a bit slow.

Here is a patch proposal of plugins/download/download.py for revision 300:
* import pyexiv from jbrout (otherwise, not found)
* catch an exception while getting thumbnail data
* disconnect the model from the view for faster imLst building
This was very quick, hence please review carefully before thinking using it.

Suggestion:
When using the download plugin with jbrout option normalizeName=1 to auto 
rename during import, since the file is first downloaded then renamed, the 
status detection (Downloaded/New) is usually wrong.
A workaround is to set the nameFormat in the download plugin preferences to 
match the jbrout normalizeNameFormat results.
It would be really nice to provide a check-box to do that automatically, all 
the more that the pattern formats are different: p%Y%m%d_%H%M%S is to be 
written p{Y}{m}{D}_{t}

Hope this will help...

Original issue reported on code.google.com by julien.d...@gmail.com on 7 Jul 2010 at 10:29

Attachments:

GoogleCodeExporter commented 8 years ago 
 - The pyexiv import part of this issue was fixed in r302.  
 - I will hopefully take a look at catching the exception while fetching thumbnail data soon and will hopefully sort this at a lower level
 - I will take a look at the disconnection of the model from the view separately as well
 - This functionality that generates the file names is in a separate code module from the download plug-in core code(nameBuilder.py & nameBuilder.glade) so this could be split out and become the library to do all of the file re-naming on import or be used as a plug-in. (The reason I suggest using the download plugin code to replace the existing jbrout code is that it is significantly more powerful and can do many more things than the current jbrout re-naming code.  )

Original comment by r...@wallace.gen.nz on 8 Jan 2011 at 10:05

GoogleCodeExporter commented 8 years ago 
Exception during fetching of thumbnail data is fixed in r326.  

The disconnection of the model from the view does significantly speed things up 
but needs some more work to remove the possibility of jBrout crashing 
spectacularly if the reading/updating of data is interrupted with the model 
disconnected from the view.

That said, I am of two minds on implementing this as the reason that the table 
update runs as a background task with the yield statements is to allow the user 
top both interrupt the process and see the updates happening, particularly when 
pulling the information off slow media such as flash devices.

Original comment by r...@wallace.gen.nz on 9 Jan 2011 at 8:02

GoogleCodeExporter commented 8 years ago 
I think I have updated version of the patch which fits to r329.

Original comment by matej.c...@gmail.com on 5 Jul 2011 at 11:40

Attachments:

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r336.

Original comment by r...@wallace.gen.nz on 6 Jul 2011 at 2:36

GoogleCodeExporter commented 8 years ago 
Am I crazy or we are still missing this from the patch?

Original comment by matej.c...@gmail.com on 8 Oct 2012 at 9:55

Attachments:

GoogleCodeExporter commented 8 years ago 
Final changes added in r348

Original comment by matej.c...@gmail.com on 12 Nov 2012 at 6:36