peircej / jbrout

Automatically exported from code.google.com/p/jbrout
0 stars 0 forks source link

tags do not show in full view #221

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open image with tags in full view (nb, image not edited with shotview, which 
doesn't have categories in tags)
2. Activate sidebar (with "Insert" key)
3.

What is the expected output? What do you see instead?
Tags are not visible

What version of the product are you using? On what operating system?
More or less latest SVN revision (r366), on Ubuntu 13.10

Please provide any additional information below.

This apparently stems from commit r361: 

    Don't put categories into tags shown in full-screen view.

    Some program (e.g., Shotwell) puts categories as tags into each photo,
    because apparently they have hierarchical tags and they don't have
    a concept of separate categories which are not tags.

    Fixes #219

In winshow.py: 

+            # we should filter out Categories ... some other programs, e.g.
+            # Shotwell, add these among Tags of the photo
+            if i not in valid_categories:
+                continue

It seems we are doing the contrary of what is expected, i.e. we only keep 
categories, instead of filtering them. 

Original issue reported on code.google.com by chartier...@gmail.com on 8 Feb 2014 at 2:24