pekim / gobbi

gobbi is a set of generated Go bindings for gtk et al.
MIT License
28 stars 3 forks source link

callback function signatures changed #13

Closed rythmkraze closed 4 years ago

rythmkraze commented 4 years ago

It appears that the "signal" callback function signatures have changed since the last time I played around with gobbi. There appears to be a redundant parameter targetObject introduced, which matches the "C" style non-object oriented API, but should not be necessary since the callbacks are passed to methods on the same targetObject.

For example in file lib/gtk/v-3.22.29.go

type WidgetSignalButtonPressEventCallback func(targetObject *Widget, event *gdk.EventButton) bool

func (recv *Widget) ConnectButtonPressEvent(callback WidgetSignalButtonPressEventCallback) int 
rythmkraze commented 4 years ago

Please ignore. I think its working as expected.

pekim commented 4 years ago

This was indeed a breaking api change, in v0.1.0. As the release notes explain, the change was introduced to work with the support for connecting signals defined in a builder definition.

rythmkraze commented 4 years ago

Thank you for explaining :)