pelagios / peripleo2

The Pelagios Exploration Engine
Other
21 stars 1 forks source link

TEI import stabilization #162

Closed rsimon closed 7 years ago

rsimon commented 7 years ago

The TEI import is still rather prototypical. When importing a large text, the following two aspects cause problems:

rsimon commented 7 years ago

TEI conversion was now revised completely (commit 7727c9ee5db7a96493d2a6976b985ba69ffcd6f3). Annotation import I just tried with a 5k+ document (The Histories) and things worked fine. Need to check the code though to confirm this is actually safe, not just a luck with a freshly-started & otherwise idle instance of ElasticSearch.

rsimon commented 7 years ago

Checked the code. References are imported through the bulk API, plus the import is integrated with the standard failure/retry mechanism, i.e. this works:

https://github.com/pelagios/peripleo2/blob/master/app/services/item/importers/BaseImporter.scala#L92-L100

Earlier failures were actually a consequence of the broken TEI conversion, which was fixed in 7727c9ee5db7a96493d2a6976b985ba69ffcd6f3.