Open jankaszel opened 4 years ago
I agree, and would be inclined to add that. Feel free to make the pull request.
One comment though: the Webpack stuff was only a sort-of intermediate phase, as far as the client-side code of Recogito is concerned.
Alright, I see! I just noticed that the external dependency could be resolved quite easily with this. I'll create the PR soon 👍
Right now, Webpack has to be installed globally via
npm i -g webpack webpack-cli
. This could be circumvented by installing it directly via asdevDependency
and creating an npm script. With that, we could reduce additional steps required during setup and pin webpack to particular versions for ensuring consistency.That would entail adapting the sbt build scripts (for example, running
npm run dev
instead ofwebpack --watch
).I'm happy to submit a PR for that, but I'm unsure what effects that could have on existing installations. With Docker it's easy to implement, but what about Vagrant, for instance?