search

pelahi / VELOCIraptor-STF

Galaxy/(sub)Halo finder for N-body simulations
MIT License
19 stars 26 forks source link

Fixes a few memory leaks in the VR library #27

Closed MatthieuSchaller closed 5 years ago

MatthieuSchaller commented 5 years ago

There is one other big one left:

Direct leak of 12582912 byte(s) in 3 object(s) allocated from:
    #0 0x7f9c40567618 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0618)
    #1 0x5555ace9853b in NBody::KDTree::FOFCriterionSetBasisForLinks(int (*)(NBody::Particle&, NBody::Particle&, double*), double*, long long&, long long, int, int, int (*)(NBody::Particle&, double*), int*, int\
*, int*, int*) /home/matthieu/Desktop/VELOCIraptor/VELOCIraptor-STF/NBodylib/src/KDTree/KDFOF.cxx:244
    #2 0x5555ace4c80f in SearchFullSet(Options&, long long, std::vector<NBody::Particle, std::allocator<NBody::Particle> >&, long long&) /home/matthieu/Desktop/VELOCIraptor/VELOCIraptor-STF/src/search.cxx:88
    #3 0x5555accea966 in InvokeVelociraptor /home/matthieu/Desktop/VELOCIraptor/VELOCIraptor-STF/src/swiftinterface.cxx:397
    #4 0x5555acbab129 in velociraptor_invoke /home/matthieu/Desktop/Swift-git/master/swiftsim/src/velociraptor_interface.c:513
    #5 0x5555acaec808 in engine_check_for_dumps /home/matthieu/Desktop/Swift-git/master/swiftsim/src/engine.c:3284
    #6 0x5555acafb3bd in engine_step /home/matthieu/Desktop/Swift-git/master/swiftsim/src/engine.c:3148
    #7 0x5555aca8067c in main /home/matthieu/Desktop/Swift-git/master/swiftsim/examples/main.c:1030
    #8 0x7f9c3dcb8b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)

but I am not sure where it is best to release that memory.

There are a few extra bytes here=and-there as well which at this stage may not matter. Altough it could be because they correspond to small arrays since there are no groups in the early snapshots.