search

pelahi / VELOCIraptor-STF

Galaxy/(sub)Halo finder for N-body simulations
MIT License
19 stars 26 forks source link

Fixed missing for loop to allow for compilation with stars #42

Closed JBorrow closed 5 years ago

JBorrow commented 5 years ago

Looks like this line was missing a loop over chunks. I don't actually know what this code does, but every other reading routine has it.

This is only seen if trying to compile with -DVR_WITH_STAR=ON.

rtobar commented 5 years ago

@JBorrow I actually tried compiling the latest master only with -DVR_WITH_STAR=ON and saw a bunch of other errors apart from that. Did you encounter those as well? It seems the code in principle should support this settings on its own right, but at the moment only works correctly if you specify -DVR_WITH_GAS=ON as well (hence the Travis builds haven't failed).

Please let me know if you find see these extra errors I'm mentioning. If you do, would you like to try fixing those as well? I feel like I don't have enough knowledge on how to fix them myself. Or if you prefer, you can just work around this problem for the time being by adding the additional GAS option to the build; in that case I'd rather leave this PR on hold until Pascal is back and has some time to look into it.

MatthieuSchaller commented 5 years ago

My 2 cents that you can happily ignore: I would think that compiling with stars only makes sense if you also have gas.