Star formation rates in EAGLE/SWIFT

pelahi / VELOCIraptor-STF

Galaxy/(sub)Halo finder for N-body simulations

MIT License

19 stars 26 forks source link

Star formation rates in EAGLE/SWIFT #43

Closed JBorrow closed 5 years ago

JBorrow commented 5 years ago

Currently start formation rates are calculated as sum(sfr_of_particles_in_x). This is incorrect, as the particle data carries the following (in postprocessing):

If positive: current star formation rate
If negative: the last time at which the gas particle was star forming.

This leads to massively negative reported star formation rates for many gas properties.

pelahi commented 5 years ago

Hi @JBorrow @MatthieuSchaller this is easy enough to fix so that all particles that have sfr<0 are set to zero but do we want to keep the information of when a gas particle was last star forming as well?

MatthieuSchaller commented 5 years ago

No, not in the halo catalogues.